Removed antlr from the dependency#12623
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Mar 11, 2024
Merged
Conversation
mcvsubbu
added
dependencies
Yuyaoo
approved these changes
Mar 11, 2024
Contributor
Yuyaoo
left a comment
Yuyaoo
left a comment
There was a problem hiding this comment.
lgtm, thank you for the changes!
Jackie-Jiang
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency on antlr causes problems in our build environment as it changes versions.
We should no longer depend on antlr in the main pom since pinot does not use antlr anymore (PQL is removed)