use static TypeReference object

[sullis]

No description provided.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.11%. Comparing base (59551e4) to head (5bc4376).
Report is 244 commits behind head on master.

Files	Patch %	Lines
...a/org/apache/pinot/common/minion/MinionClient.java	35.71%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12776      +/-   ##
============================================
+ Coverage     61.75%   62.11%   +0.36%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2492      +56     
  Lines        133233   135952    +2719     
  Branches      20636    21036     +400     
============================================
+ Hits          82274    84443    +2169     
- Misses        44911    45262     +351     
- Partials       6048     6247     +199     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	62.06% <35.71%> (+0.35%)	⬆️
java-21	61.96% <35.71%> (+0.33%)	⬆️
skip-bytebuffers-false	62.10% <35.71%> (+0.35%)	⬆️
skip-bytebuffers-true	61.91% <35.71%> (+34.18%)	⬆️
temurin	62.11% <35.71%> (+0.36%)	⬆️
unittests	62.10% <35.71%> (+0.36%)	⬆️
unittests1	46.97% <35.71%> (+0.08%)	⬆️
unittests2	27.75% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sullis]

ready for review

[sullis]

please review @gortiz @Jackie-Jiang

[Jackie-Jiang]

Let's add a method Map<String, Object> stringToMap(String jsonString) into JsonUtils

[sullis]

Let's add a method Map<String, Object> stringToMap(String jsonString) into JsonUtils

would you prefer Map<String, Object> or Map<String, String>

MinionClient uses Map<String, String>

[Jackie-Jiang]

Sorry didn't notice these 2 references are different.. In that case the previous commit is more clear

[sullis]

Sorry didn't notice these 2 references are different.. In that case the previous commit is more clear

Ack. I have removed JsonUtils stringToMap. I just pushed the revert.

[sullis]

Test suite passes

[sullis]

Ready for review