Update ControllerAdminApiApplication.java#13132
Closed
sar12332111 wants to merge 1 commit intoapache:masterfrom
Closed
Update ControllerAdminApiApplication.java#13132sar12332111 wants to merge 1 commit intoapache:masterfrom
sar12332111 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you share more context on this type of attacks and and best practice to defend it
| } | ||
| } | ||
| } | ||
| public class SafeStaticHttpHandler extends CLStaticHttpHandler { |
Contributor
There was a problem hiding this comment.
Please reformat the changes following Pinot Style
Author
There was a problem hiding this comment.
https://github.com/apache/pinot/pull/13124/files
contributed to this PR . closing this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13132 +/- ##
=============================================
- Coverage 61.75% 46.83% -14.92%
- Complexity 207 1084 +877
=============================================
Files 2436 1913 -523
Lines 133233 101274 -31959
Branches 20636 16324 -4312
=============================================
- Hits 82274 47434 -34840
- Misses 44911 50358 +5447
+ Partials 6048 3482 -2566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure static file handling to prevent path traversal attacks