Add a new transformer config to allow customization of json key value…#13421
Open
chenboat wants to merge 4 commits intoapache:masterfrom
Open
Add a new transformer config to allow customization of json key value…#13421chenboat wants to merge 4 commits intoapache:masterfrom
chenboat wants to merge 4 commits intoapache:masterfrom
Conversation
lnbest0707
reviewed
Jun 18, 2024
| import static org.testng.Assert.assertNotNull; | ||
| import static org.testng.Assert.assertNull; | ||
| import static org.testng.Assert.assertTrue; | ||
| import static org.testng.Assert.*; |
Contributor
There was a problem hiding this comment.
IDE issue? Avoid import *
| return _jsonKeyValueSeparator; | ||
| } | ||
|
|
||
| public void setJsonKeyValueSeparator(String jsonKeyValueSeparator) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void setJsonKeyValueSeparator(String jsonKeyValueSeparator) { | |
| public void setJsonKeyValueSeparator(@Nullable String jsonKeyValueSeparator) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… separator. The current separator selection of : should be deprecated because it often collides with : in json text and thus cause parsing errors.