add feature flag for recent TextIndex optimizations #13577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
added
enhancement
release-notes
itschrispeck
approved these changes
Jul 10, 2024
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13577 +/- ##
============================================
+ Coverage 61.75% 62.03% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2558 +122
Lines 133233 140968 +7735
Branches 20636 21869 +1233
============================================
+ Hits 82274 87448 +5174
- Misses 44911 46883 +1972
- Partials 6048 6637 +589
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jul 11, 2024
Jackie-Jiang
added
the
Configuration
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jul 24, 2024
* add feature flag for recent TextIndex optimizations * expand the reuseParams test data * add cache size config for NRT cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature flag for two optimizations for TextIndex recently: 1) reuse mutable index when converting mutable segment to immutable segment; 2) use NRT caching for mutable segment.
The feature flags are added to TextIndex config, as listed below
I set them to false by default so one can enable them incrementally. As those are validated more widely and we can set them to true by default to keep them on by default.