missed one util method that should derive partition id from uploaded segment name#13612
Merged
klsince merged 2 commits intoapache:masterfrom Jul 16, 2024
Merged
Conversation
klsince
changed the title
Jackie-Jiang
approved these changes
Jul 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13612 +/- ##
============================================
+ Coverage 61.75% 61.97% +0.21%
+ Complexity 207 198 -9
============================================
Files 2436 2554 +118
Lines 133233 140493 +7260
Branches 20636 21816 +1180
============================================
+ Hits 82274 87065 +4791
- Misses 44911 46818 +1907
- Partials 6048 6610 +562
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rajagopr
pushed a commit
to rajagopr/pinot
that referenced
this pull request
Jul 17, 2024
…segment name (apache#13612) * add one util method to derive partition id from uploaded segment names to avoid missing the segment name checks * add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed one util method which should try to get partition id from uploaded realtime segment directly, so extracted a util method to avoid