Skip to content

Support ISO8601 Timestamp parser#13667

Merged
xiangfu0 merged 1 commit into
apache:masterfrom
xiangfu0:iso-8601-formatter-in-TimestampUtils
Jul 22, 2024
Merged

Support ISO8601 Timestamp parser#13667
xiangfu0 merged 1 commit into
apache:masterfrom
xiangfu0:iso-8601-formatter-in-TimestampUtils

Conversation

@xiangfu0
Copy link
Copy Markdown
Contributor

@xiangfu0 xiangfu0 commented Jul 20, 2024

Use a univeral time format to parse existing DataTime format as well ISO8601 format, also supports zoned information.

@xiangfu0 xiangfu0 force-pushed the iso-8601-formatter-in-TimestampUtils branch from c9affe8 to 1480e84 Compare July 20, 2024 07:36
@xiangfu0 xiangfu0 requested a review from Jackie-Jiang July 20, 2024 07:36
@xiangfu0 xiangfu0 added enhancement Improvement to existing functionality user-experience Related to user experience labels Jul 20, 2024
Comment thread pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimestampUtils.java Outdated
Comment thread pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimestampUtils.java Outdated
@xiangfu0 xiangfu0 force-pushed the iso-8601-formatter-in-TimestampUtils branch 2 times, most recently from b74aac7 to 60fd786 Compare July 22, 2024 13:37
@xiangfu0 xiangfu0 force-pushed the iso-8601-formatter-in-TimestampUtils branch from 60fd786 to 6fbe210 Compare July 22, 2024 13:59
@apache apache deleted a comment from codecov-commenter Jul 22, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.15%. Comparing base (59551e4) to head (6fbe210).
Report is 794 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (6fbe210). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (59551e4) HEAD (6fbe210)
temurin 12 10
skip-bytebuffers-true 3 2
skip-bytebuffers-false 7 6
unittests 5 2
java-11 5 3
unittests2 3 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13667       +/-   ##
=============================================
- Coverage     61.75%   35.15%   -26.60%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2479       +43     
  Lines        133233   136845     +3612     
  Branches      20636    21299      +663     
=============================================
- Hits          82274    48104    -34170     
- Misses        44911    85089    +40178     
+ Partials       6048     3652     -2396     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 35.12% <100.00%> (-26.59%) ⬇️
java-21 35.03% <100.00%> (-26.60%) ⬇️
skip-bytebuffers-false 35.15% <100.00%> (-26.60%) ⬇️
skip-bytebuffers-true <0.01% <0.00%> (-27.73%) ⬇️
temurin 35.15% <100.00%> (-26.60%) ⬇️
unittests 46.45% <100.00%> (-15.29%) ⬇️
unittests1 46.45% <100.00%> (-0.44%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 self-assigned this Jul 22, 2024
@xiangfu0 xiangfu0 merged commit 15a8f16 into apache:master Jul 22, 2024
@xiangfu0 xiangfu0 deleted the iso-8601-formatter-in-TimestampUtils branch July 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to existing functionality user-experience Related to user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants