Support apply logical type recursively to decode Avro message#13669
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Jul 25, 2024
Merged
Support apply logical type recursively to decode Avro message#13669xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13669 +/- ##
============================================
+ Coverage 61.75% 61.99% +0.24%
+ Complexity 207 198 -9
============================================
Files 2436 2554 +118
Lines 133233 140516 +7283
Branches 20636 21857 +1221
============================================
+ Hits 82274 87110 +4836
- Misses 44911 46768 +1857
- Partials 6048 6638 +590
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sajjad-moradi
approved these changes
Jul 24, 2024
Contributor
sajjad-moradi
left a comment
sajjad-moradi
left a comment
There was a problem hiding this comment.
LGTM. Could you please add test cases for nullable fields? The reason I'm asking for it is that nullables are common in Avro as new fields added to the existing schemas need to be defined as nullable.
Specifically, it would be nice to add the following fields to the schema of your test case:
- nullable with primitive
- nullable with GenericRecord
- nullable with LogicalType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Avro decoder doesn't apply logical type decoder recursively inside Array or Map.
This PR implements the recursive logical for complex schema.
#13670