Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

Address remaining comments for #13863

@Jackie-Jiang Jackie-Jiang requested a review from klsince September 9, 2024 19:34
@Jackie-Jiang Jackie-Jiang force-pushed the relocator_rebalance_config_followup branch from 81c8da8 to 7b9ba11 Compare September 9, 2024 19:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (59551e4) to head (7b9ba11).
Report is 1010 commits behind head on master.

Files with missing lines Patch % Lines
...roller/helix/core/relocation/SegmentRelocator.java 54.54% 5 Missing ⚠️
...va/org/apache/pinot/controller/ControllerConf.java 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13963      +/-   ##
============================================
- Coverage     61.75%   57.96%   -3.79%     
+ Complexity      207      199       -8     
============================================
  Files          2436     2595     +159     
  Lines        133233   142947    +9714     
  Branches      20636    21962    +1326     
============================================
+ Hits          82274    82864     +590     
- Misses        44911    53600    +8689     
- Partials       6048     6483     +435     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 57.94% <75.00%> (-3.77%) ⬇️
java-21 57.82% <75.00%> (-3.80%) ⬇️
skip-bytebuffers-false 57.95% <75.00%> (-3.79%) ⬇️
skip-bytebuffers-true 57.79% <75.00%> (+30.06%) ⬆️
temurin 57.96% <75.00%> (-3.79%) ⬇️
unittests 57.96% <75.00%> (-3.79%) ⬇️
unittests1 40.77% <ø> (-6.12%) ⬇️
unittests2 27.95% <75.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit f157858 into apache:master Sep 9, 2024
@Jackie-Jiang Jackie-Jiang deleted the relocator_rebalance_config_followup branch September 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants