Skip to content

minor: changes as a follow up PR#14000

Merged
Jackie-Jiang merged 5 commits intoapache:masterfrom
anandheritage:anandsh/tenant-followup
Sep 15, 2024
Merged

minor: changes as a follow up PR#14000
Jackie-Jiang merged 5 commits intoapache:masterfrom
anandheritage:anandsh/tenant-followup

Conversation

@anandheritage
Copy link
Contributor

Follow up changes of this PR : #13954

  1. variable name change
  2. Java doc addition

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.92%. Comparing base (59551e4) to head (1dac494).
Report is 1036 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pinot/common/utils/helix/HelixHelper.java 50.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14000      +/-   ##
============================================
- Coverage     61.75%   57.92%   -3.83%     
- Complexity      207      219      +12     
============================================
  Files          2436     2613     +177     
  Lines        133233   143270   +10037     
  Branches      20636    21995    +1359     
============================================
+ Hits          82274    82995     +721     
- Misses        44911    53781    +8870     
- Partials       6048     6494     +446     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 57.88% <50.00%> (-3.83%) ⬇️
java-21 57.78% <50.00%> (-3.85%) ⬇️
skip-bytebuffers-false 57.91% <50.00%> (-3.84%) ⬇️
skip-bytebuffers-true 57.75% <50.00%> (+30.02%) ⬆️
temurin 57.92% <50.00%> (-3.83%) ⬇️
unittests 57.92% <50.00%> (-3.83%) ⬇️
unittests1 40.72% <50.00%> (-6.17%) ⬇️
unittests2 27.98% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing them

@Jackie-Jiang Jackie-Jiang merged commit 4a26fba into apache:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants