minor: changes as a follow up PR#14000
Merged
Jackie-Jiang merged 5 commits intoapache:masterfrom Sep 15, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14000 +/- ##
============================================
- Coverage 61.75% 57.92% -3.83%
- Complexity 207 219 +12
============================================
Files 2436 2613 +177
Lines 133233 143270 +10037
Branches 20636 21995 +1359
============================================
+ Hits 82274 82995 +721
- Misses 44911 53781 +8870
- Partials 6048 6494 +446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Sep 15, 2024
Contributor
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Thank you for addressing them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up changes of this PR : #13954