Test Classes Refactoring for setters of _textIndexColumns and ColumnProperties (IndexLoadingConfig) #14153
Merged
Jackie-Jiang merged 38 commits intoapache:masterfrom Oct 5, 2024
Merged
Conversation
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
Enforce removeSegment flow with _enableDeletedKeysCompactionConsisten…
reverse merge
Reverse merge from master
reverse merge
reverse merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14153 +/- ##
============================================
+ Coverage 61.75% 63.78% +2.03%
- Complexity 207 1532 +1325
============================================
Files 2436 2621 +185
Lines 133233 144074 +10841
Branches 20636 22041 +1405
============================================
+ Hits 82274 91901 +9627
- Misses 44911 45372 +461
- Partials 6048 6801 +753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deepthi912
changed the title
merge master
Jackie-Jiang
added
testing
Jackie-Jiang
approved these changes
Oct 4, 2024
pinot-core/src/test/java/org/apache/pinot/queries/NoDictionaryCompressionQueriesTest.java
Outdated
Show resolved
Hide resolved
pinot-core/src/test/java/org/apache/pinot/queries/FastFilteredCountTest.java
Outdated
Show resolved
Hide resolved
pinot-core/src/test/java/org/apache/pinot/queries/FastFilteredCountTest.java
Outdated
Show resolved
Hide resolved
pinot-core/src/test/java/org/apache/pinot/queries/NativeAndLuceneComparisonTest.java
Outdated
Show resolved
Hide resolved
| new FieldConfig(SKILLS_TEXT_MV_COL_DICT_NAME, FieldConfig.EncodingType.DICTIONARY, FieldConfig.IndexType.TEXT, | ||
| null, null)); | ||
|
|
||
| _tableConfig = new TableConfigBuilder(TableType.OFFLINE).setTableName(TABLE_NAME) |
Contributor
There was a problem hiding this comment.
Seems we are not reusing table config here. Do we need to construct a new one from scratch?
Collaborator
Author
There was a problem hiding this comment.
In buildSegment() we created one which doesn't include any column properties for field configs to be used in SegmentGeneratorConfig, so tried to create a new one for this with properties included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #14106
Below test classes are modified: