add preloading support for dedup tables#14187
Merged
klsince merged 3 commits intoapache:masterfrom Oct 22, 2024
Merged
Conversation
klsince
force-pushed
the
preload_dedup_table
branch
from
3492d7a to
897fe74
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14187 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1535 +1328
============================================
Files 2436 2626 +190
Lines 133233 144765 +11532
Branches 20636 22152 +1516
============================================
+ Hits 82274 92272 +9998
- Misses 44911 45686 +775
- Partials 6048 6807 +759
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
added
feature
dedup
Jackie-Jiang
approved these changes
Oct 9, 2024
klsince
force-pushed
the
preload_dedup_table
branch
from
897fe74 to
fd5a1b6
Compare
klsince
force-pushed
the
preload_dedup_table
branch
from
fd5a1b6 to
bd3ad54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add preloading support for dedup tables to bootstrap dedup metadata faster during server restarts or table rebalances.
The overall preloading logic is similar with the one made for upsert table, but is a bit simpler because dedup table doesn't use validDocIds bitmaps to track PKs and it assumes all ingested immutable segments have no duplicate PKs. When preloading segments, we can update dedup metadata more efficiently, like simply doing map.put() instead of map.compute() which does get-check-set conditionally.