Cleanup UpsertCompaction validations during task-generation#14424
Merged
swaminathanmanish merged 1 commit intoapache:masterfrom Nov 12, 2024
Merged
Cleanup UpsertCompaction validations during task-generation#14424swaminathanmanish merged 1 commit intoapache:masterfrom
swaminathanmanish merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14424 +/- ##
============================================
+ Coverage 61.75% 63.79% +2.04%
- Complexity 207 1565 +1358
============================================
Files 2436 2661 +225
Lines 133233 145998 +12765
Branches 20636 22360 +1724
============================================
+ Hits 82274 93146 +10872
- Misses 44911 45969 +1058
- Partials 6048 6883 +835
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
approved these changes
Nov 12, 2024
Contributor
swaminathanmanish
left a comment
swaminathanmanish
left a comment
There was a problem hiding this comment.
Thanks for cleaning up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up to #14340. Now that we have moved validations to table-config creation / modification, removing the redundancy during task-generation process.
cc @swaminathanmanish @rajagopr