Revert "Using local copy of segment instead of downloading from remote (#14429)"#14484
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Nov 19, 2024
Merged
Conversation
apache#14429)" This reverts commit b90d1da.
abhioncbr
approved these changes
Nov 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14484 +/- ##
============================================
+ Coverage 61.75% 63.75% +2.00%
- Complexity 207 1566 +1359
============================================
Files 2436 2667 +231
Lines 133233 146413 +13180
Branches 20636 22470 +1834
============================================
+ Hits 82274 93343 +11069
- Misses 44911 46154 +1243
- Partials 6048 6916 +868
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Nov 22, 2024
apache#14429)" (apache#14484) This reverts commit b90d1da.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting 14429 since the change is not setting the segment download URL correctly. Will re-introduce with proper fix later.