Fix flaky quota integration tests#14602
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Dec 10, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14602 +/- ##
============================================
+ Coverage 61.75% 64.02% +2.27%
- Complexity 207 1573 +1366
============================================
Files 2436 2687 +251
Lines 133233 147785 +14552
Branches 20636 22648 +2012
============================================
+ Hits 82274 94618 +12344
- Misses 44911 46230 +1319
- Partials 6048 6937 +889
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
reviewed
Dec 5, 2024
...tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
xiangfu0
approved these changes
Dec 5, 2024
Jackie-Jiang
approved these changes
Dec 5, 2024
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
LGTM with minor comments
...tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR improves sleep-related timing logic that made QueryQuotaClusterIntegrationTest flaky.