Skip to content

Upgrade Helix to 1.4.2#14648

Closed
Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Jackie-Jiang:upgrade_helix
Closed

Upgrade Helix to 1.4.2#14648
Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Jackie-Jiang:upgrade_helix

Conversation

@Jackie-Jiang
Copy link
Copy Markdown
Contributor

No description provided.

@Jackie-Jiang Jackie-Jiang added the dependencies Pull requests that update a dependency file label Dec 12, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.21%. Comparing base (59551e4) to head (b063ca1).
Report is 2287 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (b063ca1). Click for more details.

HEAD has 44 uploads less than BASE
Flag BASE (59551e4) HEAD (b063ca1)
integration 7 0
integration2 3 0
temurin 12 3
java-21 7 2
skip-bytebuffers-true 3 1
skip-bytebuffers-false 7 2
unittests 5 3
java-11 5 1
unittests2 3 0
integration1 2 0
custom-integration1 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14648      +/-   ##
============================================
- Coverage     61.75%   56.21%   -5.54%     
- Complexity      207      791     +584     
============================================
  Files          2436     2119     -317     
  Lines        133233   111891   -21342     
  Branches      20636    17775    -2861     
============================================
- Hits          82274    62900   -19374     
+ Misses        44911    44024     -887     
+ Partials       6048     4967    -1081     
Flag Coverage Δ
custom-integration1 ?
integration ?
integration1 ?
integration2 ?
java-11 56.16% <ø> (-5.55%) ⬇️
java-21 56.06% <ø> (-5.57%) ⬇️
skip-bytebuffers-false 56.18% <ø> (-5.57%) ⬇️
skip-bytebuffers-true 56.04% <ø> (+28.31%) ⬆️
temurin 56.21% <ø> (-5.54%) ⬇️
unittests 56.21% <ø> (-5.54%) ⬇️
unittests1 56.21% <ø> (+9.32%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang
Copy link
Copy Markdown
Contributor Author

The failures are caused by a behavior change from Helix: apache/helix#2982

@abhioncbr
Copy link
Copy Markdown
Contributor

The failures are caused by a behavior change from Helix: apache/helix#2982

This is similar on the lines of our last upgrade try

@Jackie-Jiang Jackie-Jiang deleted the upgrade_helix branch February 1, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants