[flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultiStageEngineIntegrationTest#14653
Merged
Merged
Conversation
Jackie-Jiang
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14653 +/- ##
============================================
+ Coverage 61.75% 63.97% +2.22%
- Complexity 207 1600 +1393
============================================
Files 2436 2696 +260
Lines 133233 148392 +15159
Branches 20636 22740 +2104
============================================
+ Hits 82274 94941 +12667
- Misses 44911 46476 +1565
- Partials 6048 6975 +927
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
So one of the integration tests in this run failed with the following. I am covering the MultistageEngineIntegrationTest too now. cc: @Jackie-Jiang |
yashmayya
approved these changes
Dec 13, 2024
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
…StageEngineIntegrationTest (apache#14653)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14099
Default timeout for broker-read is 60s, and the other two timeouts are 2s. This increases the broker-read timeout to 120s, and the others to 60 seconds.
The queries for TPCH can be expensive so that may be one reason for timeouts.