Skip to content

[flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultiStageEngineIntegrationTest#14653

Merged
ankitsultana merged 3 commits into
apache:masterfrom
ankitsultana:tpch-test
Dec 17, 2024
Merged

[flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultiStageEngineIntegrationTest#14653
ankitsultana merged 3 commits into
apache:masterfrom
ankitsultana:tpch-test

Conversation

@ankitsultana
Copy link
Copy Markdown
Contributor

@ankitsultana ankitsultana commented Dec 12, 2024

fixes #14099

Default timeout for broker-read is 60s, and the other two timeouts are 2s. This increases the broker-read timeout to 120s, and the others to 60 seconds.

The queries for TPCH can be expensive so that may be one reason for timeouts.

@ankitsultana ankitsultana added the flaky-test Tracks a test that intermittently fails label Dec 12, 2024
@ankitsultana ankitsultana changed the title [flaky-test] Try to Fix Flaky TPCHQueryIntegrationTest [flaky-test] Increase Timeouts for TPCHQueryIntegrationTest Dec 12, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (59551e4) to head (f37c445).
Report is 2193 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14653      +/-   ##
============================================
+ Coverage     61.75%   63.97%   +2.22%     
- Complexity      207     1600    +1393     
============================================
  Files          2436     2696     +260     
  Lines        133233   148392   +15159     
  Branches      20636    22740    +2104     
============================================
+ Hits          82274    94941   +12667     
- Misses        44911    46476    +1565     
- Partials       6048     6975     +927     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.93% <ø> (+2.23%) ⬆️
java-21 63.87% <ø> (+2.24%) ⬆️
skip-bytebuffers-false 63.95% <ø> (+2.21%) ⬆️
skip-bytebuffers-true 63.85% <ø> (+36.12%) ⬆️
temurin 63.97% <ø> (+2.22%) ⬆️
unittests 63.97% <ø> (+2.22%) ⬆️
unittests1 56.19% <ø> (+9.30%) ⬆️
unittests2 34.53% <ø> (+6.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankitsultana
Copy link
Copy Markdown
Contributor Author

So one of the integration tests in this run failed with the following. I am covering the MultistageEngineIntegrationTest too now.

cc: @Jackie-Jiang

Pinot query: SELECT MAX(CAST("OriginWac" AS DOUBLE)), COUNT("ArrDelay") FROM mytable WHERE "DepDelayMinutes" <= 40.0 GROUP BY "ActualElapsedTime", "ArrDel15" HAVING MAX("OriginWac") > 8529.041 AND MIN("DestWac") <> 9003.317 AND COUNT("DestCityName") <= 737 OR SUM("AirlineID") <= 3086.881 LIMIT 10000
H2 query: SELECT MAX(CAST(`OriginWac` AS DOUBLE)), COUNT(`ArrDelay`) FROM mytable WHERE `DepDelayMinutes` <= 40.0 GROUP BY `ActualElapsedTime`, `ArrDel15` HAVING MAX(`OriginWac`) > 8529.041 AND MIN(`DestWac`) <> 9003.317 AND COUNT(`DestCityName`) <= 737 OR SUM(`AirlineID`) <= 3086.881 LIMIT 10000
	at org.testng.Assert.fail(Assert.java:99)
	...
Caused by: org.apache.pinot.client.PinotClientException: java.util.concurrent.TimeoutException
	at org.apache.pinot.client.JsonAsyncHttpPinotClientTransport.executeQuery(JsonAsyncHttpPinotClientTransport.java:102)
	... 34 more
Caused by: java.util.concurrent.TimeoutException
	at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)
	at org.apache.pinot.client.JsonAsyncHttpPinotClientTransport.executeQuery(JsonAsyncHttpPinotClientTransport.java:100)
	... 38 more

@ankitsultana ankitsultana changed the title [flaky-test] Increase Timeouts for TPCHQueryIntegrationTest [flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultistageEngineIntegrationTest Dec 13, 2024
@ankitsultana ankitsultana changed the title [flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultistageEngineIntegrationTest [flaky-test] Increase Timeouts for TPCHQueryIntegrationTest and MultiStageEngineIntegrationTest Dec 13, 2024
@ankitsultana ankitsultana merged commit 246b98c into apache:master Dec 17, 2024
zeronerdzerogeekzerocool pushed a commit to zeronerdzerogeekzerocool/pinot that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Tracks a test that intermittently fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky Tests: TPCHQueryIntegrationTest and pinot-kafka-3.0

4 participants