Skip optimizing IN predicate when it contains too many values#14670
Closed
Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Closed
Skip optimizing IN predicate when it contains too many values#14670Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14670 +/- ##
============================================
+ Coverage 61.75% 63.99% +2.24%
- Complexity 207 1604 +1397
============================================
Files 2436 2703 +267
Lines 133233 148926 +15693
Branches 20636 22820 +2184
============================================
+ Hits 82274 95310 +13036
- Misses 44911 46627 +1716
- Partials 6048 6989 +941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Dec 30, 2024
Contributor
Author
|
Prefer #14732 over this. We can revisit this later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeEqInFilterOptimizermaintains a set of thriftExpressionforINpredicate values. It is very expensive to calculate hash code forExpression, thus we limit the values allowed to apply the optimizer