Added SegmentGeneratorConfig as an optional param to the SegmentPurger#14872
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Jan 28, 2025
Merged
Added SegmentGeneratorConfig as an optional param to the SegmentPurger#14872Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14872 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1470 +1263
============================================
Files 2436 2713 +277
Lines 133233 151717 +18484
Branches 20636 23417 +2781
============================================
+ Hits 82274 96697 +14423
- Misses 44911 47767 +2856
- Partials 6048 7253 +1205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rajagopr
force-pushed
the
add-segment-gen-config
branch
3 times, most recently
from
1827152 to
6c6e81a
Compare
Jackie-Jiang
approved these changes
Jan 28, 2025
pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java
Outdated
Show resolved
Hide resolved
rajagopr
force-pushed
the
add-segment-gen-config
branch
from
6c6e81a to
e839ce0
Compare
Jackie-Jiang
added
ingestion
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow passing
SegmentGeneratorCustomConfigas an optional param to the SegmentPurger class. TheSegmentGeneratorConfigcan be customized using the configs supplied via theSegmentGeneratorCustomConfigclass. This is required to add functionality that swaps segments atomically post the purge operation using the segment replacement protocol.