Allow overriding cluster configs in quickstarts#14919
Merged
yashmayya merged 1 commit intoapache:masterfrom Feb 8, 2025
Merged
Allow overriding cluster configs in quickstarts#14919yashmayya merged 1 commit intoapache:masterfrom
yashmayya merged 1 commit intoapache:masterfrom
Conversation
Contributor
yashmayya
commented
Jan 25, 2025
yashmayya
commented
- The quickstarts currently allow overriding controller / broker / server / minion configs but not cluster configs.
- This patch allows overriding cluster configs in quickstarts which is useful to easily test scenarios involving custom cluster configurations.
yashmayya
force-pushed
the
quickstart-cluster-config-override
branch
from
171838a to
d5848d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14919 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1470 +1263
============================================
Files 2436 2708 +272
Lines 133233 151544 +18311
Branches 20636 23400 +2764
============================================
+ Hits 82274 96590 +14316
- Misses 44911 47702 +2791
- Partials 6048 7252 +1204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Feb 7, 2025
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.