Skip to content

Make fields protected for DefaultRebalancePreChecker#15091

Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom
somandal:rebalance-pre-checks-minor-fix
Feb 20, 2025
Merged

Make fields protected for DefaultRebalancePreChecker#15091
Jackie-Jiang merged 2 commits intoapache:masterfrom
somandal:rebalance-pre-checks-minor-fix

Conversation

@somandal
Copy link
Contributor

This PR makes the executorService and pinotHelixResourceManager fields of DefaultRebalancePreChecker class as protected

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (59551e4) to head (81d5743).
Report is 1738 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15091      +/-   ##
============================================
+ Coverage     61.75%   63.39%   +1.64%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2744     +308     
  Lines        133233   154078   +20845     
  Branches      20636    23781    +3145     
============================================
+ Hits          82274    97683   +15409     
- Misses        44911    49017    +4106     
- Partials       6048     7378    +1330     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.36% <ø> (+1.65%) ⬆️
java-21 63.27% <ø> (+1.64%) ⬆️
skip-bytebuffers-false 63.38% <ø> (+1.63%) ⬆️
skip-bytebuffers-true 63.25% <ø> (+35.52%) ⬆️
temurin 63.39% <ø> (+1.64%) ⬆️
unittests 63.39% <ø> (+1.64%) ⬆️
unittests1 56.06% <ø> (+9.16%) ⬆️
unittests2 33.88% <ø> (+6.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@somandal
Copy link
Contributor Author

test failure seems transient, passes when i run it locally:

Error:    OfflineClusterIntegrationTest.testStringComparisonInFilter:3494->BaseClusterIntegrationTest.getType:742 » NullPointer Cannot invoke "com.fasterxml.jackson.databind.JsonNode.get(String)" because the return value of "com.fasterxml.jackson.databind.JsonNode.get(String)" is null

@somandal somandal requested a review from klsince February 19, 2025 19:14
@Jackie-Jiang Jackie-Jiang merged commit f9750e2 into apache:master Feb 20, 2025
21 of 22 checks passed
@somandal somandal deleted the rebalance-pre-checks-minor-fix branch February 20, 2025 16:00
zeronerdzerogeekzerocool pushed a commit to zeronerdzerogeekzerocool/pinot that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants