Changes to support parallel test runs#15170
Draft
krishan1390 wants to merge 1 commit intoapache:masterfrom
Draft
Changes to support parallel test runs#15170krishan1390 wants to merge 1 commit intoapache:masterfrom
krishan1390 wants to merge 1 commit intoapache:masterfrom
Conversation
krishan1390
commented
Mar 4, 2025
| if (adminApiPortString != null) { | ||
| listeners.add( | ||
| new ListenerConfig(CommonConstants.HTTP_PROTOCOL, DEFAULT_HOST, Integer.parseInt(adminApiPortString), | ||
| new ListenerConfig(CommonConstants.HTTP_PROTOCOL, DEFAULT_HOST, NetUtils.findOpenPort(Integer.parseInt(adminApiPortString)), |
Contributor
Author
There was a problem hiding this comment.
this isn't meant for production because we should stick to configured port (for non test flow) rather than determine an available port. so will refactor this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15170 +/- ##
==============================================
+ Coverage 61.75% 100.00% +38.24%
+ Complexity 207 6 -201
==============================================
Files 2436 3 -2433
Lines 133233 6 -133227
Branches 20636 0 -20636
==============================================
- Hits 82274 6 -82268
+ Misses 44911 0 -44911
+ Partials 6048 0 -6048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.