Fix GET /queries broker API UnsupportedOperationException bug#15200
Merged
yashmayya merged 1 commit intoapache:masterfrom Mar 5, 2025
Merged
Fix GET /queries broker API UnsupportedOperationException bug#15200yashmayya merged 1 commit intoapache:masterfrom
yashmayya merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15200 +/- ##
============================================
+ Coverage 61.75% 63.53% +1.78%
- Complexity 207 1457 +1250
============================================
Files 2436 2759 +323
Lines 133233 155308 +22075
Branches 20636 23913 +3277
============================================
+ Hits 82274 98672 +16398
- Misses 44911 49186 +4275
- Partials 6048 7450 +1402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Mar 5, 2025
Contributor
gortiz
left a comment
gortiz
left a comment
There was a problem hiding this comment.
Good catch. In general we should not modify collections returned by other structures (and we should a bit less nice and return unmodifiable structures to be sure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /queriesfailed with anUnsupportedOperationExceptionerror because we're trying to update an unmodifiable map.