Skip to content

Migrate H3 v3 api to v4#15313

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:migrate_h3_core
Mar 19, 2025
Merged

Migrate H3 v3 api to v4#15313
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:migrate_h3_core

Conversation

@Jackie-Jiang
Copy link
Contributor

Migrate usage of H3CoreV3 to H3Core (V4)

Incompatible

H3Utils.H3_CORE is changed from H3CoreV3 to H3Core

@Jackie-Jiang Jackie-Jiang added incompatible geo Related to geospatial features labels Mar 19, 2025
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 March 19, 2025 19:39
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (59551e4) to head (5a9e95c).
Report is 1873 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pinot/segment/local/utils/H3Utils.java 35.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15313      +/-   ##
============================================
+ Coverage     61.75%   63.66%   +1.90%     
- Complexity      207     1459    +1252     
============================================
  Files          2436     2781     +345     
  Lines        133233   156822   +23589     
  Branches      20636    24061    +3425     
============================================
+ Hits          82274    99834   +17560     
- Misses        44911    49480    +4569     
- Partials       6048     7508    +1460     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.57% <51.85%> (+1.87%) ⬆️
java-21 63.56% <51.85%> (+1.93%) ⬆️
skip-bytebuffers-false 63.64% <51.85%> (+1.89%) ⬆️
skip-bytebuffers-true 63.49% <51.85%> (+35.76%) ⬆️
temurin 63.66% <51.85%> (+1.90%) ⬆️
unittests 63.65% <51.85%> (+1.90%) ⬆️
unittests1 56.13% <48.14%> (+9.24%) ⬆️
unittests2 34.21% <11.11%> (+6.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit 4526397 into apache:master Mar 19, 2025
22 checks passed
@Jackie-Jiang Jackie-Jiang deleted the migrate_h3_core branch March 19, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

geo Related to geospatial features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants