Revert the null value handling in AggregationResultsBlock when nullHandlingEnabled is false#15382
Merged
Jackie-Jiang merged 1 commit intomasterfrom Mar 27, 2025
Merged
Conversation
jackjlli
added a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, when the result value is null, it will be handled in the following method regardless of the value of
nullHandlingEnabled.While that PR changes the behavior that the result should not be null only when
nullHandlingEnabledis set to true, and this breaks some of the use cases running in production. Here is the sample exception:And in fact, if the
aggregate(int length, AggregationResultHolder aggregationResultHolder, Map<ExpressionContext, BlockValSet> blockValSetMap)method never gets invoked, theObject _value;inside theAggregationResultHolderclass will be null, which is a valid case (we can see from the above query log that 0 segment gets processed).This PR adds back the logic to handle the case when the result could be null.