Fix the completed segment check when trying to add it as consuming segment#15401
Closed
Jackie-Jiang wants to merge 1 commit into
Closed
Fix the completed segment check when trying to add it as consuming segment#15401Jackie-Jiang wants to merge 1 commit into
Jackie-Jiang wants to merge 1 commit into
Conversation
Jackie-Jiang
added
ingestion
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15401 +/- ##
============================================
+ Coverage 61.75% 63.21% +1.46%
- Complexity 207 1375 +1168
============================================
Files 2436 2813 +377
Lines 133233 159065 +25832
Branches 20636 24360 +3724
============================================
+ Hits 82274 100551 +18277
- Misses 44911 50909 +5998
- Partials 6048 7605 +1557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When segment is completed, regardless of wither consumption order is enforced, we should skip adding it as consuming segment, and wait for
CONSUMING -> ONLINEstate transition to bring it directlyONLINE