Skip to content

Conversation

@9aman
Copy link
Contributor

@9aman 9aman commented Apr 8, 2025

Scope of the PR

  • The znode of contains committing segments for a pauseless table was kept dangling when a table was deleted.
  • The changes allow deletion of this node when a table is deleted
  • The deletion will happen for Realtime tables irrespective of whether pauseless is enabled or not
    • This has been done to ensure that the COMMITTING segments are cleared for a table for which pauseless has been disabled

List of API's that will trigger this deletion

/tables/{tableName}
/tableConfigs/{tableName}
/databases/{databaseName}

Handling deleted segments

  • The removal of deleted segments from this metadata is already handled by the function getCommittingSegments called from syncCommittingSegments

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.90%. Comparing base (59551e4) to head (2d93d04).
Report is 2011 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pinot/common/metadata/ZKMetadataProvider.java 0.00% 4 Missing ⚠️
...ntroller/helix/core/PinotHelixResourceManager.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15487      +/-   ##
============================================
+ Coverage     61.75%   62.90%   +1.15%     
- Complexity      207     1375    +1168     
============================================
  Files          2436     2848     +412     
  Lines        133233   161179   +27946     
  Branches      20636    24694    +4058     
============================================
+ Hits          82274   101391   +19117     
- Misses        44911    52130    +7219     
- Partials       6048     7658    +1610     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 62.85% <0.00%> (+1.14%) ⬆️
java-21 62.88% <0.00%> (+1.25%) ⬆️
skip-bytebuffers-false 62.89% <0.00%> (+1.14%) ⬆️
skip-bytebuffers-true 62.86% <0.00%> (+35.13%) ⬆️
temurin 62.90% <0.00%> (+1.15%) ⬆️
unittests 62.90% <0.00%> (+1.15%) ⬆️
unittests1 55.90% <0.00%> (+9.01%) ⬆️
unittests2 33.57% <0.00%> (+5.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0 xiangfu0 merged commit 252cd44 into apache:master Apr 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants