Skip to content

[Issue 12676 - Part 2.2] Define versions from submodule POMs in root POM#15501

Merged
siddharthteotia merged 2 commits intoapache:masterfrom
leujean02:refactor-dependencies
Apr 9, 2025
Merged

[Issue 12676 - Part 2.2] Define versions from submodule POMs in root POM#15501
siddharthteotia merged 2 commits intoapache:masterfrom
leujean02:refactor-dependencies

Conversation

@leujean02
Copy link
Contributor

@leujean02 leujean02 commented Apr 8, 2025

Continuing work on the proposal outlined in issue #12676.

I have made the following changes:

  1. Moved the version declarations from submodules' POM files to the root POM.
    • Affected dependencies:
      • com.adobe.testing:s3mock-testcontainers
      • cloud.localstack:localstack-utils
  2. Declared the dependency versions in the root POM and replaced the hardcoded numbers with the variables defined in the root POM
    • Affected dependencies:
      • net.sourceforge.fmpp:fmpp
      • com.github.os72:protobuf-dynamic
  3. There is a version conflict between scala-library 2.12.20 (from the root POM) and 2.13.16 (from pinot-confluent-json). I used maven-shade-plugin to relocate the scala-library dependency from pinot-confluent-json plugin.

cc @siddharthteotia @gviedma

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (59551e4) to head (a78a32b).
Report is 2018 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15501      +/-   ##
============================================
+ Coverage     61.75%   62.90%   +1.14%     
- Complexity      207     1375    +1168     
============================================
  Files          2436     2848     +412     
  Lines        133233   161183   +27950     
  Branches      20636    24694    +4058     
============================================
+ Hits          82274   101385   +19111     
- Misses        44911    52142    +7231     
- Partials       6048     7656    +1608     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 62.85% <ø> (+1.14%) ⬆️
java-21 62.87% <ø> (+1.25%) ⬆️
skip-bytebuffers-false 62.89% <ø> (+1.14%) ⬆️
skip-bytebuffers-true 62.86% <ø> (+35.13%) ⬆️
temurin 62.90% <ø> (+1.14%) ⬆️
unittests 62.89% <ø> (+1.14%) ⬆️
unittests1 55.92% <ø> (+9.03%) ⬆️
unittests2 33.56% <ø> (+5.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@siddharthteotia siddharthteotia merged commit d7b1763 into apache:master Apr 9, 2025
24 checks passed
@leujean02 leujean02 deleted the refactor-dependencies branch April 9, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants