set tables for controller task scheduling#15594
Merged
jtao15 merged 1 commit intoapache:masterfrom Apr 18, 2025
Merged
Conversation
Contributor
Author
sajjad-moradi
approved these changes
Apr 18, 2025
Contributor
sajjad-moradi
left a comment
sajjad-moradi
left a comment
There was a problem hiding this comment.
LGTM. I believe we should add tests to make sure this won't happen in future. It can be on a separate PR though.
jtao15
pushed a commit
that referenced
this pull request
Apr 18, 2025
jtao15
pushed a commit
that referenced
this pull request
Apr 18, 2025
leujean02
pushed a commit
to leujean02/pinot
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for #15592.
If not set
setTablesToSchedule(), the all controllers will generate tasks for all tables, which causes the minions to do lots of duplicated work.