Verify if skipped submodule POMs contain hardcoded versions#15816
Merged
siddharthteotia merged 65 commits intoapache:masterfrom May 16, 2025
Merged
Verify if skipped submodule POMs contain hardcoded versions#15816siddharthteotia merged 65 commits intoapache:masterfrom
siddharthteotia merged 65 commits intoapache:masterfrom
Conversation
…ersion in root POM
…ersion in root POM
fixed build
Write a script to enforce guidelines during PR check-in
...dency-verifier/src/main/java/org/apache/pinot/verifier/PinotCustomDependencyVersionRule.java
Outdated
Show resolved
Hide resolved
| "Root POM has hardcoded version '%s' in <dependencyManagement> for %s:%s. " | ||
| + "Please refer to https://docs.pinot.apache.org/developers/developers-and-contributors" | ||
| + "/dependency-management for the best practice", | ||
| d.getVersion(), d.getGroupId(), d.getArtifactId() |
There was a problem hiding this comment.
What would be the value project.getArtifactId() for the root POM?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15816 +/- ##
============================================
+ Coverage 62.90% 63.37% +0.47%
- Complexity 1386 1394 +8
============================================
Files 2867 2898 +31
Lines 163354 165899 +2545
Branches 24952 25383 +431
============================================
+ Hits 102755 105140 +2385
+ Misses 52847 52817 -30
- Partials 7752 7942 +190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
siddharthteotia
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix from #15739, which installs the Maven Enforcer plugin with custom rules to validate dependency declarations and enforce the Dependency Management Guidelines across all POM files in Pinot. This PR verifies if any skipped submodules (e.g. pinot-plugins, pinot-connectors etc.) POMs contain hardcoded versions