Check batchSizePerServer in Rebalance Config Pre-check#15984
Merged
somandal merged 5 commits intoapache:masterfrom Jun 4, 2025
Merged
Check batchSizePerServer in Rebalance Config Pre-check#15984somandal merged 5 commits intoapache:masterfrom
batchSizePerServer in Rebalance Config Pre-check#15984somandal merged 5 commits intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15984 +/- ##
============================================
+ Coverage 62.90% 63.42% +0.52%
+ Complexity 1386 1355 -31
============================================
Files 2867 2910 +43
Lines 163354 166846 +3492
Branches 24952 25518 +566
============================================
+ Hits 102755 105826 +3071
- Misses 52847 53025 +178
- Partials 7752 7995 +243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the newly added rebalance config
batchSizePerServer(#15617), this PR adds a new logic in rebalance config pre-check in table rebalance pre-checker to warn user when this parameter is recommended to be set.When the number of segments to add to a single server is too large,
batchSizePerServeris expected to be set to protect the server from stranded by helix messages. Currently this pre-check warns when any server will have more than200segments to add to, showing message to recommend user to setbatchSizePerServerto200or lower.Examples
Rebalance a table with

batchSizePerServer=-1Rebalance a table with

batchSizePerServer=500The same table with

batchSizePerServer=200