Generate minion tasks for the servers in ONLINE state in External for segments in Upsert Table#16182
Closed
deepthi912 wants to merge 1 commit intoapache:masterfrom
Closed
Generate minion tasks for the servers in ONLINE state in External for segments in Upsert Table#16182deepthi912 wants to merge 1 commit intoapache:masterfrom
deepthi912 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better way of doing : #16165
When generating Upsert Compaction or Merge tasks on minion, it is advised to check the external view state of segments for which servers are
ONLINEinstead of checking the ideal state. During restart phase for servers orERRORstate of segments, the bit maps are a bit inconsistent. We do the same check on executor today but not on generator logic. This PR addresses that gap.