Skip to content

Formatting clean-up for rebalance#16266

Merged
somandal merged 3 commits intoapache:masterfrom
somandal:rebalance-format-fix
Jul 2, 2025
Merged

Formatting clean-up for rebalance#16266
somandal merged 3 commits intoapache:masterfrom
somandal:rebalance-format-fix

Conversation

@somandal
Copy link
Copy Markdown
Contributor

@somandal somandal commented Jul 2, 2025

This PR just cleans up some formatting in the TableRebalancer and DefaultRebalancePreChecker classes. No functionality changes are included

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 42.22222% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.21%. Comparing base (1a476de) to head (9e13241).
Report is 397 commits behind head on master.

Files with missing lines Patch % Lines
...ntroller/helix/core/rebalance/TableRebalancer.java 46.66% 16 Missing ⚠️
...lix/core/rebalance/DefaultRebalancePreChecker.java 33.33% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16266      +/-   ##
============================================
+ Coverage     62.90%   63.21%   +0.31%     
+ Complexity     1386     1363      -23     
============================================
  Files          2867     2962      +95     
  Lines        163354   171471    +8117     
  Branches      24952    26272    +1320     
============================================
+ Hits         102755   108396    +5641     
- Misses        52847    54852    +2005     
- Partials       7752     8223     +471     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.18% <42.22%> (+0.31%) ⬆️
java-21 63.19% <42.22%> (+0.37%) ⬆️
skip-bytebuffers-false ?
skip-bytebuffers-true ?
temurin 63.21% <42.22%> (+0.31%) ⬆️
unittests 63.21% <42.22%> (+0.31%) ⬆️
unittests1 64.76% <ø> (+8.94%) ⬆️
unittests2 33.38% <42.22%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang added minor Small or trivial change cleanup Code cleanup or removal of dead code labels Jul 2, 2025
@somandal
Copy link
Copy Markdown
Contributor Author

somandal commented Jul 2, 2025

Test failure is unrelated and is a known flaky test:

Error:  Failures: 
Error:    TableRebalancePauselessIntegrationTest.testForceCommit:184->BaseClusterIntegrationTestSet.waitForRebalanceToComplete:824 Failed to meet condition in 30000ms, error message: Failed to complete rebalance
Error:    TableRebalancePauselessIntegrationTest.testForceCommit:184->BaseClusterIntegrationTestSet.waitForRebalanceToComplete:824 Failed to meet condition in 30000ms, error message: Failed to complete rebalance

@somandal somandal merged commit 9621990 into apache:master Jul 2, 2025
35 of 36 checks passed
@somandal somandal deleted the rebalance-format-fix branch July 2, 2025 23:25
@xiangfu0 xiangfu0 added the segment-rebalance Related to segment rebalancing across servers label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup or removal of dead code minor Small or trivial change segment-rebalance Related to segment rebalancing across servers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants