Test Aggregate orderby merge threshold#16313
Closed
songwdfu wants to merge 12 commits intoapache:masterfrom
Closed
Test Aggregate orderby merge threshold#16313songwdfu wants to merge 12 commits intoapache:masterfrom
songwdfu wants to merge 12 commits intoapache:masterfrom
Conversation
change implementation to comparing set of column identifiers. cache after first call to the function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16313 +/- ##
============================================
+ Coverage 62.90% 63.24% +0.34%
+ Complexity 1386 1364 -22
============================================
Files 2867 2973 +106
Lines 163354 172584 +9230
Branches 24952 26434 +1482
============================================
+ Hits 102755 109153 +6398
- Misses 52847 55093 +2246
- Partials 7752 8338 +586
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GroupByCombineOperator.
…ermediateRecord when orderby groupby key
only sort aggregate when limit is smaller than the threshold, todo is to make this a queryOption
ce23804 to
07a0038
Compare
Contributor
Author
|
Closing as this is in corporated in the latest impl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test