Skip to content

Test Aggregate orderby merge threshold#16313

Closed
songwdfu wants to merge 12 commits intoapache:masterfrom
songwdfu:aggregate-orderby-merge-threshold
Closed

Test Aggregate orderby merge threshold#16313
songwdfu wants to merge 12 commits intoapache:masterfrom
songwdfu:aggregate-orderby-merge-threshold

Conversation

@songwdfu
Copy link
Contributor

@songwdfu songwdfu commented Jul 9, 2025

test

change implementation to comparing set of column identifiers. cache
after first call to the function.
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 82.83262% with 40 lines in your changes missing coverage. Please review.

Project coverage is 63.24%. Comparing base (1a476de) to head (07a0038).
Report is 426 commits behind head on master.

Files with missing lines Patch % Lines
.../core/operator/combine/GroupByCombineOperator.java 75.75% 9 Missing and 7 partials ⚠️
...not/core/data/table/LinkedHashMapIndexedTable.java 74.07% 6 Missing and 8 partials ⚠️
...not/core/query/utils/OrderByComparatorFactory.java 90.00% 2 Missing and 3 partials ⚠️
...t/core/operator/query/FilteredGroupByOperator.java 81.25% 1 Missing and 2 partials ⚠️
...org/apache/pinot/core/data/table/TableResizer.java 92.85% 0 Missing and 1 partial ⚠️
...pinot/core/query/request/context/QueryContext.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16313      +/-   ##
============================================
+ Coverage     62.90%   63.24%   +0.34%     
+ Complexity     1386     1364      -22     
============================================
  Files          2867     2973     +106     
  Lines        163354   172584    +9230     
  Branches      24952    26434    +1482     
============================================
+ Hits         102755   109153    +6398     
- Misses        52847    55093    +2246     
- Partials       7752     8338     +586     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.22% <82.83%> (+0.35%) ⬆️
java-21 63.19% <82.83%> (+0.36%) ⬆️
skip-bytebuffers-false ?
skip-bytebuffers-true ?
temurin 63.24% <82.83%> (+0.34%) ⬆️
unittests 63.24% <82.83%> (+0.34%) ⬆️
unittests1 56.46% <82.83%> (+0.64%) ⬆️
unittests2 33.20% <0.42%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@songwdfu songwdfu force-pushed the aggregate-orderby-merge-threshold branch from ce23804 to 07a0038 Compare July 9, 2025 20:58
@songwdfu
Copy link
Contributor Author

Closing as this is in corporated in the latest impl

@songwdfu songwdfu closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants