Skip to content

[BugFix] Serialize TlsSpec when executing DataIngestion backfill job#16381

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
hongkunxu:fix/serialize-tlsspec-when-backfill
Jul 23, 2025
Merged

[BugFix] Serialize TlsSpec when executing DataIngestion backfill job#16381
Jackie-Jiang merged 1 commit intoapache:masterfrom
hongkunxu:fix/serialize-tlsspec-when-backfill

Conversation

@hongkunxu
Copy link
Contributor

Fixes a NotSerializableException caused by TlsSpec not implementing Serializable.
Added implements Serializable to TlsSpec to allow objects containing it to be serialized properly during DataIngestion Backfill job execution.

Signed-off-by: Hongkun Xu <xuhongkun666@163.com>
@hongkunxu hongkunxu changed the title [bugfix] Serialize TlsSpec when executing DataIngestion backfill job [BugFix] Serialize TlsSpec when executing DataIngestion backfill job Jul 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.31%. Comparing base (1a476de) to head (df8865f).
Report is 471 commits behind head on master.

Files with missing lines Patch % Lines
...apache/pinot/spi/ingestion/batch/spec/TlsSpec.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16381      +/-   ##
============================================
+ Coverage     62.90%   63.31%   +0.41%     
+ Complexity     1386     1363      -23     
============================================
  Files          2867     2976     +109     
  Lines        163354   172777    +9423     
  Branches      24952    26459    +1507     
============================================
+ Hits         102755   109402    +6647     
- Misses        52847    55029    +2182     
- Partials       7752     8346     +594     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.27% <0.00%> (+0.40%) ⬆️
java-21 63.29% <0.00%> (+0.47%) ⬆️
skip-bytebuffers-false ?
skip-bytebuffers-true ?
temurin 63.31% <0.00%> (+0.41%) ⬆️
unittests 63.31% <0.00%> (+0.41%) ⬆️
unittests1 56.44% <0.00%> (+0.62%) ⬆️
unittests2 33.31% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit b9e5116 into apache:master Jul 23, 2025
18 checks passed
@Jackie-Jiang Jackie-Jiang added the ingestion Related to data ingestion pipeline label Jul 23, 2025
@xiangfu0 xiangfu0 added the bug Something is not working as expected label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working as expected ingestion Related to data ingestion pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants