add latency metric for multistage queries#16398
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Jul 21, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16398 +/- ##
============================================
+ Coverage 62.90% 63.32% +0.41%
+ Complexity 1386 1364 -22
============================================
Files 2867 2976 +109
Lines 163354 172928 +9574
Branches 24952 26497 +1545
============================================
+ Hits 102755 109502 +6747
- Misses 52847 55052 +2205
- Partials 7752 8374 +622
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
approved these changes
Jul 21, 2025
xiangfu0
added
multi-stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a latency metric for v2 engine queries. It follows the existing pattern of reusing the same "global" metric name for both global and per-table latencies. This is unlikely to be ideal or useful in every case for tracking latency for v2 engine queries, but it 1) follows the pattern set for other metrics and 2) is strictly better than what we have today which is no metrics
the change looks a little weird because I also refactored the other metrics to only iterate the tables once.