Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

VARIANT and UUID were introduced in Calcite 1.39.0
Mark them as non reserved keyword to maintain backward compatibility

@Jackie-Jiang Jackie-Jiang added backward-incompat Referenced by PRs that introduce or fix backward compat issues query labels Jul 30, 2025
case "VARCHAR":
_resultMetadata = sourceSV ? STRING_SV_NO_DICTIONARY_METADATA : STRING_MV_NO_DICTIONARY_METADATA;
break;
case "JSON":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to this PR. Just making the order consistent with DataType definition for readability

@Jackie-Jiang Jackie-Jiang force-pushed the non_reserved_keyword branch from 7f627a7 to a019393 Compare July 30, 2025 19:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (e2f8077) to head (a019393).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ator/transform/function/CastTransformFunction.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16471      +/-   ##
============================================
- Coverage     63.22%   63.22%   -0.01%     
  Complexity     1363     1363              
============================================
  Files          3005     3005              
  Lines        174066   174066              
  Branches      26637    26637              
============================================
- Hits         110061   110049      -12     
- Misses        55616    55628      +12     
  Partials       8389     8389              
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.17% <0.00%> (+29.96%) ⬆️
java-21 63.20% <0.00%> (-0.03%) ⬇️
temurin 63.22% <0.00%> (-0.01%) ⬇️
unittests 63.21% <0.00%> (-0.01%) ⬇️
unittests1 56.38% <0.00%> (+0.03%) ⬆️
unittests2 33.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit b6f0319 into apache:master Jul 30, 2025
18 checks passed
@Jackie-Jiang Jackie-Jiang deleted the non_reserved_keyword branch July 30, 2025 20:58
@jadami10
Copy link
Contributor

Mark them as non reserved keyword to maintain backward compatibility

we noticed the original upgrade broke some queries for us, but we fixed that with quoting. Was this breaking something else?

@Jackie-Jiang
Copy link
Contributor Author

Mark them as non reserved keyword to maintain backward compatibility

we noticed the original upgrade broke some queries for us, but we fixed that with quoting. Was this breaking something else?

With the original upgrade, uuid and variant cannot be directly used as column name. Double quoting them should fix the problem. With this PR, double quoting is no longer needed to maintain the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward-incompat Referenced by PRs that introduce or fix backward compat issues query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants