-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Make VARIANT/UUID non reserved keyword #16471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| case "VARCHAR": | ||
| _resultMetadata = sourceSV ? STRING_SV_NO_DICTIONARY_METADATA : STRING_MV_NO_DICTIONARY_METADATA; | ||
| break; | ||
| case "JSON": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to this PR. Just making the order consistent with DataType definition for readability
7f627a7 to
a019393
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16471 +/- ##
============================================
- Coverage 63.22% 63.22% -0.01%
Complexity 1363 1363
============================================
Files 3005 3005
Lines 174066 174066
Branches 26637 26637
============================================
- Hits 110061 110049 -12
- Misses 55616 55628 +12
Partials 8389 8389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
we noticed the original upgrade broke some queries for us, but we fixed that with quoting. Was this breaking something else? |
With the original upgrade, |
VARIANTandUUIDwere introduced in Calcite1.39.0Mark them as non reserved keyword to maintain backward compatibility