Remove TaskType from ThreadExecutionContext#16633
Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom Aug 19, 2025
Merged
Conversation
xiangfu0
approved these changes
Aug 19, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16633 +/- ##
============================================
+ Coverage 63.28% 63.33% +0.04%
Complexity 1379 1379
============================================
Files 3027 3026 -1
Lines 176446 176434 -12
Branches 27074 27073 -1
============================================
+ Hits 111671 111743 +72
+ Misses 56203 56120 -83
+ Partials 8572 8571 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
J-HowHuang
added a commit
to J-HowHuang/pinot
that referenced
this pull request
Aug 19, 2025
This reverts commit 72bf3bf.
Jackie-Jiang
added a commit
that referenced
this pull request
Aug 19, 2025
This reverts commit 72bf3bf.
Jackie-Jiang
pushed a commit
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the TaskType enum from ThreadExecutionContext and simplifies the threading accounting code by removing unnecessary task type tracking. The changes include updating setupRunner and setupWorker methods to remove taskType parameters, updating all call sites across broker, core, query-runtime, and SPI modules, and updating test cases to reflect the API changes.
NOTE: ThreadAccountant related functions are changed in SPI, but they should be internal only as of now