Skip to content

Remove TaskType from ThreadExecutionContext#16633

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_task_type
Aug 19, 2025
Merged

Remove TaskType from ThreadExecutionContext#16633
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:remove_task_type

Conversation

@Jackie-Jiang
Copy link
Copy Markdown
Contributor

@Jackie-Jiang Jackie-Jiang commented Aug 19, 2025

This PR removes the TaskType enum from ThreadExecutionContext and simplifies the threading accounting code by removing unnecessary task type tracking. The changes include updating setupRunner and setupWorker methods to remove taskType parameters, updating all call sites across broker, core, query-runtime, and SPI modules, and updating test cases to reflect the API changes.

NOTE: ThreadAccountant related functions are changed in SPI, but they should be internal only as of now

@Jackie-Jiang Jackie-Jiang added the cleanup Code cleanup or removal of dead code label Aug 19, 2025
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 August 19, 2025 17:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.33%. Comparing base (962f45c) to head (2bb2998).

Files with missing lines Patch % Lines
...requesthandler/MultiStageBrokerRequestHandler.java 0.00% 1 Missing ⚠️
...accounting/CPUMemThreadLevelAccountingObjects.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16633      +/-   ##
============================================
+ Coverage     63.28%   63.33%   +0.04%     
  Complexity     1379     1379              
============================================
  Files          3027     3026       -1     
  Lines        176446   176434      -12     
  Branches      27074    27073       -1     
============================================
+ Hits         111671   111743      +72     
+ Misses        56203    56120      -83     
+ Partials       8572     8571       -1     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.25% <90.47%> (-0.02%) ⬇️
java-21 63.31% <90.47%> (+0.05%) ⬆️
temurin 63.33% <90.47%> (+0.04%) ⬆️
unittests 63.33% <90.47%> (+0.04%) ⬆️
unittests1 56.44% <94.73%> (+0.03%) ⬆️
unittests2 33.17% <4.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit 72bf3bf into apache:master Aug 19, 2025
16 of 18 checks passed
@Jackie-Jiang Jackie-Jiang deleted the remove_task_type branch August 19, 2025 19:11
J-HowHuang added a commit to J-HowHuang/pinot that referenced this pull request Aug 19, 2025
Jackie-Jiang added a commit that referenced this pull request Aug 19, 2025
Jackie-Jiang pushed a commit that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup or removal of dead code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants