Skip to content

[bugfix] Fixing the TableType value passed for unavailable segments in physical optimizer#16660

Merged
ankitsultana merged 1 commit intoapache:masterfrom
shauryachats:physical_opt_tabletype_bugfix
Aug 22, 2025
Merged

[bugfix] Fixing the TableType value passed for unavailable segments in physical optimizer#16660
ankitsultana merged 1 commit intoapache:masterfrom
shauryachats:physical_opt_tabletype_bugfix

Conversation

@shauryachats
Copy link
Copy Markdown
Collaborator

Summary

An issue was discovered while querying a table with unavailable segments with the physical optimizer enabled.

Error Code: 150 (SQLParsingError)

SQLParsingError: Error composing query plan: No enum constant org.apache.pinot.spi.config.table.TableType.my_table_name.

This was due to the tableName incorrectly passed instead of tableType for TableType.valueOf().

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.29%. Comparing base (76f2b7f) to head (2822367).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...al/v2/opt/rules/LeafStageWorkerAssignmentRule.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16660      +/-   ##
============================================
- Coverage     63.32%   63.29%   -0.03%     
+ Complexity     1380     1379       -1     
============================================
  Files          3035     3035              
  Lines        176714   176714              
  Branches      27121    27121              
============================================
- Hits         111896   111843      -53     
- Misses        56232    56278      +46     
- Partials       8586     8593       +7     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.26% <0.00%> (-0.02%) ⬇️
java-21 63.26% <0.00%> (-0.04%) ⬇️
temurin 63.29% <0.00%> (-0.03%) ⬇️
unittests 63.28% <0.00%> (-0.03%) ⬇️
unittests1 56.42% <0.00%> (-0.04%) ⬇️
unittests2 33.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shauryachats shauryachats force-pushed the physical_opt_tabletype_bugfix branch from 70fa567 to 2822367 Compare August 22, 2025 04:26
@ankitsultana ankitsultana merged commit b00dbfe into apache:master Aug 22, 2025
33 of 36 checks passed
@ankitsultana ankitsultana added bugfix mse-physical-optimizer Multi-stage engine physical query optimizer labels Aug 22, 2025
@shauryachats shauryachats deleted the physical_opt_tabletype_bugfix branch August 25, 2025 01:38
@xiangfu0 xiangfu0 added the bug Something is not working as expected label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working as expected mse-physical-optimizer Multi-stage engine physical query optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants