updated putNodeData and zookeeperPutData to pass data in the payload/…#16809
updated putNodeData and zookeeperPutData to pass data in the payload/…#16809xiangfu0 merged 1 commit intoapache:masterfrom
Conversation
…body instead of a query param
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16809 +/- ##
============================================
- Coverage 63.36% 63.36% -0.01%
Complexity 1399 1399
============================================
Files 3055 3055
Lines 178916 178916
Branches 27419 27419
============================================
- Hits 113377 113362 -15
- Misses 56789 56807 +18
+ Partials 8750 8747 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Updates Zookeeper node data operations to pass data in the request payload instead of as query parameters. This change addresses an issue where large Zookeeper node data was being passed through query parameters, which can cause issues with URL length limits and is not the proper approach for data payloads.
- Modified
putNodeDatato extract data from parameters and pass it as request body - Updated
zookeeperPutDatato accept optional data parameter for request payload - Restructured parameter handling to separate query parameters from data payload
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts | Refactored putNodeData to separate data from query parameters and pass data to request body |
| pinot-controller/src/main/resources/app/requests/index.ts | Updated zookeeperPutData function signature to accept optional data parameter for request payload |
xiangfu0
left a comment
There was a problem hiding this comment.
Nice, thanks for adding this.
Now we could update larger payload through ui :)
…body instead of a query param
This screenshot shows that zk node data is now being passed via the request payload:
This fixes issue #15311