Migrate tests and connector to PinotAdminClient #17167
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates tests and connector code from the deprecated ControllerRequestClient to the newer PinotAdminClient. The migration adds missing admin client capabilities (logical table, cluster, query workload) and updates the Flink connector dependencies.
Key changes:
- Added new admin client classes for logical tables, cluster operations, and query workloads
- Updated integration tests to use
PinotAdminClientinstead ofControllerRequestClient - Modified Flink connector to depend on
pinot-java-clientinstead ofpinot-controller
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/udf/IntegrationUdfTestCluster.java |
Replaced ControllerRequestClient calls with inherited methods from base class |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/logicaltable/BaseLogicalTableIntegrationTest.java |
Removed override of getControllerRequestClient() method |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/UrlAuthRealtimeIntegrationTest.java |
Migrated segment listing to use PinotAdminClient |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SegmentGenerationMinionRealtimeIngestionTest.java |
Replaced direct schema addition call with inherited method |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryWorkloadIntegrationTest.java |
Migrated query workload operations to PinotAdminClient |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PartialUpsertTableRebalanceIntegrationTest.java |
Migrated pause/resume operations to PinotAdminClient |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterIntegrationTest.java |
Migrated periodic task execution to PinotAdminClient |
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java |
Replaced direct schema addition with inherited method |
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java |
Added PinotAdminClient integration and override methods for schema/table operations |
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java |
Migrated segment reset and listing operations to PinotAdminClient |
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java |
Migrated controller test methods to use PinotAdminClient for schema, table, and tenant operations |
pinot-controller/pom.xml |
Added pinot-java-client test dependency |
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/http/PinotConnectionUtils.java |
Updated utility methods to use PinotAdminClient |
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java |
Migrated example code to use PinotAdminClient |
pinot-connectors/pinot-flink-connector/pom.xml |
Changed dependency from pinot-controller to pinot-java-client |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotTableAdminClient.java |
Added methods for table operations (pause/resume consumption, pause status, external view, ideal state) |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSegmentAdminClient.java |
Added methods for segment operations (reload table, check reload needed, reload status) |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSchemaAdminClient.java |
Added typed getSchema() method returning Schema object |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotQueryWorkloadAdminClient.java |
New admin client for query workload configuration operations |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotLogicalTableAdminClient.java |
New admin client for logical table operations |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotClusterAdminClient.java |
New admin client for cluster-level operations |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotAdminTransport.java |
Added getScheme() accessor method |
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotAdminClient.java |
Added accessors for new admin clients and controller address/URL utilities |
...rs/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java
Show resolved
Hide resolved
...ts/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSchemaAdminClient.java
Show resolved
Hide resolved
...link-connector/src/main/java/org/apache/pinot/connector/flink/http/PinotConnectionUtils.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
feat/admin-client-migration
branch
from
23a912d to
310c7e7
Compare
❌ 62 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
xiangfu0
force-pushed
the
feat/admin-client-migration
branch
17 times, most recently
from
eced8fc to
32cd71e
Compare
xiangfu0
force-pushed
the
feat/admin-client-migration
branch
7 times, most recently
from
2727fcb to
654d391
Compare
xiangfu0
force-pushed
the
feat/admin-client-migration
branch
3 times, most recently
from
0a15faf to
21d6e39
Compare
…ients (logical table, cluster, query workload); replace ControllerRequestClient usages where possible; add pinot-java-client dep in Flink connector
xiangfu0
force-pushed
the
feat/admin-client-migration
branch
from
21d6e39 to
edef79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing admin clients (logical table, cluster, query workload);
replace ControllerRequestClient usages where possible;
add pinot-java-client dep in Flink connector