Fix non-daemon threads blocking JVM shutdown in RenewableTlsUtils #17221
+26
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where non-daemon background threads in RenewableTlsUtils prevented JVM shutdown in on-demand processes like Pinot Admin commands. The fix modifies NamedThreadFactory to support daemon thread creation and updates SSL certificate monitoring threads to use daemon mode.
Key changes:
- Enhanced
NamedThreadFactorywith an optionaldaemonparameter to control thread daemon status - Updated SSL certificate file watcher and daily reload threads to use daemon threads
- Applied the same fix to test code for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pinot-common/src/main/java/org/apache/pinot/common/utils/NamedThreadFactory.java | Added daemon parameter support to enable creating daemon threads |
| pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java | Updated SSL monitoring threads to use daemon mode via NamedThreadFactory |
| pinot-common/src/test/java/org/apache/pinot/common/utils/tls/RenewableTlsUtilsTest.java | Applied daemon thread configuration to test executor service |
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17221 +/- ##
============================================
+ Coverage 63.17% 63.20% +0.03%
Complexity 1428 1428
============================================
Files 3121 3123 +2
Lines 184814 184835 +21
Branches 28332 28323 -9
============================================
+ Hits 116760 116829 +69
+ Misses 59033 58995 -38
+ Partials 9021 9011 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16979
Problem
The
RenewableTlsUtilsprevents JVM shutdown in on-demand processes (e.g., Pinot Admin commands). Background threads monitoring SSL certificates used non-daemon threads, keeping the JVM alive indefinitely after process completion, requiring manual termination.Fix
NamedThreadFactoryusage inRenewableTlsUtilsto create daemon threads by passing true as the second constructor argumentreloadSslFactoryWhenFileStoreChangesandreloadSslFactorymethods to useNamedThreadFactorywith daemon flag enabled.