Always use singleton worker for final sort stage to ensure hotspot server rotation #17347
+42
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORDER BY/LIMIT/OFFSETqueries have two sort stages - a local / initial sort followed by an exchange and a global / final sort.https://github.com/apache/pinot/blame/d1497bf77667c165e83c357d3c3fdab5dc957216/pin[…]pache/pinot/query/planner/physical/DispatchablePlanVisitor.java).
ORDER BYandLIMIT/OFFSET. However, for queries that only haveORDER BY, or only haveLIMIT/OFFSET, the hotspot server is always the same. The reason is that the condition to set the singleton worker constraint on a sort node is!node.getCollations().isEmpty() && node.getOffset() != -1.node.getCollations()is empty for nonORDER BYqueries andnode.getOffset()is -1 for both local and global sort node forORDER BYqueries withoutLIMITandOFFSET.