Add StateTransitionThreadPoolManager to override getExecutor in SegmentOnlineOfflineStateModelFactory #17453
+97
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Pinot server uses the default Helix thread pool for state transition messages (appears as
HelixTaskExecutor-message_handle_thread_<tid>). The main concern of this is thatChanges
StateTransitionThreadPoolManagerin charge of constructing the thread pools for different state transition messagesgetExecutorServicemethods inSegmentOnlineOfflineStateModelFactoryto return the thread pools created byStateTransitionThreadPoolManagerStateTransitionThreadPoolManagerisnull, which returnsnullin all thegetExecutorServicemethod calls. This would be no difference than using the default shared thread pool in Helix. The implementation ofStateTransitionThreadPoolManagerneeds to be provided and set during pinot server start.