remove compatibility verifier for 1.3.0 #17649
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17576 we detected an issue that proves we cannot downgrade from 1.4 or 1.5 to 1.3 without downtime, as MSE queries may be broken due to an incompatibility in the stage stats. It is important to know the issue is not introduced by #17576 but detected by it.
The main issue is that in 1.4 we introduced a cluster listener that detects whether the cluster is homogeneous or not, and in case it is not, MSE doesn't send stage stats. We did that because in 1.3 we detected a bug and the only way to fix it was to change the stats in 1.4 in a way that 1.3 fails when they are received. This worked fine during the system upgrade, but the listener is based on a version-specific Helix property we started setting in 1.4. When rolling back to 1.3, that property is not changed (as it is unknown to 1.3), so the other nodes see the old value, which means they think the cluster is homogeneous.
Fixing this issue may be complex and given we don't expect people to downgrade from 1.5 to 1.3, we think it is just better to remove that check here. As always, it is recommended to upgrade one version at a time, so in case you need to downgrade from 1.5, you should go to 1.4, which is still tested.
Release noted
Apache Pinot 1.5 can be rolled back to 1.4 without downtime, but not to earlier versions. It is recommended to upgrade one version at a time.