Avoid Inconsistencies among replicas during Upsert Compaction Tasks#17695
Closed
deepthi912 wants to merge 3 commits intoapache:masterfrom
Closed
Avoid Inconsistencies among replicas during Upsert Compaction Tasks#17695deepthi912 wants to merge 3 commits intoapache:masterfrom
deepthi912 wants to merge 3 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17695 +/- ##
=========================================
Coverage 55.63% 55.64%
Complexity 721 721
=========================================
Files 2479 2479
Lines 140436 140436
Branches 22375 22375
=========================================
+ Hits 78134 78146 +12
+ Misses 55709 55700 -9
+ Partials 6593 6590 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: In addition to the inconsistencies we are seeing across replicas in upsert tables, we identified that sometimes if server restarts take very long and replica server delays an amount where there is differences in validDocIds, we have seen cases where some servers might not have snapshots on disk for validdocIds. Now let's say if a compaction task runs and take the validDocIds from server with less number of valid docs and replace with the server with higher valid DocIds.
In such cases, the rest of these valid docs are removed pointing the next entries as first rather than merging them with previous ones.