Handle stopped task queue in table task cleanup tests

[xiangfu0]

Summary

• Harden PinotTableRestletResourceTest against TaskSchedulingInfo.getScheduledTaskNames() == null when scheduling fails.
• Add getOrScheduleTask(...) helper that retries once after resuming the SegmentGenerationAndPushTask queue when queue-stopped scheduling error is returned.
• Ensure testTableTasksCleanupWithActiveTasks resumes the task queue in a finally block so queue state does not leak into subsequent tests.

Validation

Not run (not requested); this is a test-only stability change for flaky test coverage.

[Copilot]

Pull request overview

This PR updates PinotTableRestletResourceTest to reduce flakiness in testTableTasksCleanupWithActiveTasks by making minion-task state checks and deletion cleanup more race-tolerant when tables are deleted with ignoreActiveTasks=true.

Changes:

• Added helpers to wait for a task to reach a state or be missing, and to force-delete tasks with retries.
• Updated the active-task cleanup test to stop the minion task queue before waiting/deleting the task.

[Copilot]

The test stops the minion task queue but never resumes it. This can leak shared state into subsequent tests in this class/suite (note the earlier cleanup test explicitly resumes the queue “to avoid affecting other tests”). Please ensure the queue is resumed (ideally in a finally block or in @AfterMethod cleanup) even if assertions fail.

[Copilot]

isTaskStateNotFound detects 404s by substring-matching IOException.getMessage(), which is brittle and may misclassify errors if message formats change. Since the request helpers wrap HttpErrorStatusException as the IOException cause, prefer checking e.getCause() for HttpErrorStatusException and using its status code (or a dedicated helper that returns status codes) to reliably detect 404s.

[codecov-commenter]

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
9352	5	9347	48

View the top 3 failed test(s) by shortest run time

org.apache.pinot.controller.api.PinotTableRestletResourceTest::testTableTasksValidationWithDanglingTasks

Stack Traces | 0.031s run time

No scheduled task names returned from task scheduling. taskInfo: {SegmentGenerationAndPushTask=TaskSchedulingInfo{scheduledTaskNames='null', generationErrors='[]', schedulingErrors='[Unable to start scheduling for task type SegmentGenerationAndPushTask as task queue may be stopped. Please check the task queue status.]'}}

org.apache.pinot.controller.api.PinotTableRestletResourceTest::testTableTasksCleanupWithNonActiveTasks

Stack Traces | 0.049s run time

No scheduled task names returned from task scheduling. taskInfo: {SegmentGenerationAndPushTask=TaskSchedulingInfo{scheduledTaskNames='null', generationErrors='[]', schedulingErrors='[Unable to start scheduling for task type SegmentGenerationAndPushTask as task queue may be stopped. Please check the task queue status.]'}}

org.apache.pinot.controller.api.PinotTableRestletResourceTest::testTableTasksValidationWithDanglingTasks

Stack Traces | 0.06s run time

No scheduled task names returned from task scheduling. taskInfo: {SegmentGenerationAndPushTask=TaskSchedulingInfo{scheduledTaskNames='null', generationErrors='[]', schedulingErrors='[Unable to start scheduling for task type SegmentGenerationAndPushTask as task queue may be stopped. Please check the task queue status.]'}}

org.apache.pinot.controller.api.PinotTableRestletResourceTest::testTableTasksCleanupWithNonActiveTasks

Stack Traces | 0.086s run time

No scheduled task names returned from task scheduling. taskInfo: {SegmentGenerationAndPushTask=TaskSchedulingInfo{scheduledTaskNames='null', generationErrors='[]', schedulingErrors='[Unable to start scheduling for task type SegmentGenerationAndPushTask as task queue may be stopped. Please check the task queue status.]'}}

org.apache.pinot.integration.tests.WindowResourceAccountingTest::setUp

Stack Traces | 10s run time

java.lang.RuntimeException: java.io.IOException: Failed to bind to address 0.0.0.0/0.0.0.0:39295

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}