Reduce PinotHelixResourceManager public APIs#17827
Open
krishan1390 wants to merge 2 commits intoapache:masterfrom
Open
Reduce PinotHelixResourceManager public APIs#17827krishan1390 wants to merge 2 commits intoapache:masterfrom
krishan1390 wants to merge 2 commits intoapache:masterfrom
Conversation
Jackie-Jiang
reviewed
Mar 6, 2026
| * @throws IOException | ||
| * @throws TableConfigBackwardIncompatibleException if config changes are backward incompatible | ||
| */ | ||
| public void updateTableConfig(TableConfig tableConfig) |
Contributor
There was a problem hiding this comment.
I feel this method is more concise. Alternatively we can make it final to prevent wrong override. Directly removing it is backward incompatible
| * @throws IOException | ||
| * @throws TableConfigBackwardIncompatibleException if config changes are backward incompatible and force is false | ||
| */ | ||
| public void updateTableConfig(TableConfig tableConfig, boolean force) |
Contributor
There was a problem hiding this comment.
Seems it won't throw IOException as well. Let's clean it up
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17827 +/- ##
============================================
+ Coverage 63.20% 63.26% +0.05%
Complexity 1456 1456
============================================
Files 3188 3189 +1
Lines 191736 191760 +24
Branches 29347 29354 +7
============================================
+ Hits 121178 121308 +130
+ Misses 61067 60971 -96
+ Partials 9491 9481 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are currently 2 Public APIs of updateTableConfig and 3 APIs of setExistingTableConfig.
This makes overriding brittle and also makes clients harder to understand which API to call, so simplifying by keeping just one API for each method.