Fix Flink connector Kafka test dependencies#17836
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Flink connector’s integration test runtime by adding the Kafka embedded-cluster test artifacts required for EmbeddedKafkaCluster to be available on the test classpath.
Changes:
- Add
pinot-kafka-3.0test-jarto the Flink connector test dependencies soEmbeddedKafkaClusteris present. - Add Kafka
testclassifier artifacts (kafka_${scala.compat.version},kafka-clients,kafka-server-common) required by the embedded cluster test utilities.
xiangfu0
force-pushed
the
fixing-flink-test
branch
from
d09c645 to
1248b63
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17836 +/- ##
============================================
+ Coverage 55.58% 63.27% +7.69%
- Complexity 727 1466 +739
============================================
Files 2497 3190 +693
Lines 141225 191963 +50738
Branches 22529 29410 +6881
============================================
+ Hits 78499 121469 +42970
- Misses 56072 60985 +4913
- Partials 6654 9509 +2855
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add the Kafka embedded-cluster test jar and Kafka test classifier artifacts to the Flink connector test classpath so BaseClusterIntegrationTest can load EmbeddedKafkaCluster during PinotSinkUpsertTableIntegrationTest.
xiangfu0
force-pushed
the
fixing-flink-test
branch
from
1248b63 to
057f896
Compare
raghavyadav01
approved these changes
Mar 9, 2026
yashmayya
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to fix test failure for #17790
EmbeddedKafkaClusterPinotSinkUpsertTableIntegrationTestfailing withNoClassDefFoundErrorforEmbeddedKafkaClusterTesting
./mvnw -pl pinot-connectors/pinot-flink-connector -Dtest=PinotSinkUpsertTableIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test