Migrate 7 integration tests to custom package for shared cluster setup#17857
Conversation
e3c0fb0 to
b37718b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17857 +/- ##
=========================================
Coverage 63.26% 63.27%
Complexity 1466 1466
=========================================
Files 3190 3190
Lines 192039 192039
Branches 29421 29421
=========================================
+ Hits 121492 121507 +15
+ Misses 61026 61008 -18
- Partials 9521 9524 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n tests to custom package Move these tests to share a single Pinot cluster via CustomDataQueryClusterIntegrationTest (@BeforeSuite/@AfterSuite lifecycle) instead of each test starting its own cluster. This reduces total integration test setup time by eliminating 3 redundant cluster startups. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b37718b to
3482147
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates 7 Pinot integration tests into the org.apache.pinot.integration.tests.custom package so they can all run against a shared cluster lifecycle provided by CustomDataQueryClusterIntegrationTest, reducing redundant cluster startups.
Changes:
- Moved 7 tests to
org.apache.pinot.integration.tests.customand updated them to extendCustomDataQueryClusterIntegrationTest. - Updated references/imports in dependent tests to point to the new class locations and helper methods.
- Replaced the old
AggregateMetricsClusterIntegrationTestwith a newAggregateMetricsTestunder the custom suite.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/StarTreeTest.java | Migrates star-tree integration test to the shared custom cluster suite and updates table/schema setup accordingly. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/RowExpressionTest.java | Migrates row-expression coverage to the shared custom cluster suite and switches queries to use the per-test table name. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/GroupByTrimmingTest.java | Migrates group-by trimming tests to shared cluster setup and updates queries/plan assertions to use the per-test table name. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/GroupByOptionsTest.java | Migrates group-by option tests to shared cluster setup and exposes helper methods used by other tests. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/CLPEncodingRealtimeTest.java | Migrates CLP realtime ingestion test to shared cluster setup and adapts schema/data creation hooks. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/BigNumberOfSegmentsTest.java | Migrates (disabled) large-segment-count test to shared cluster setup. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/AggregateMetricsTest.java | Adds aggregate-metrics realtime test to the shared custom suite, replacing the prior standalone version. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MultiColumnTextIndicesTest.java | Updates static import to reference the moved GroupByOptionsTest helper. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/StarTreeFunctionParametersIntegrationTest.java | Updates constant reference import to the migrated StarTreeTest. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/GroupByEnableTrimOptionIntegrationTest.java | Updates helper method references to GroupByOptionsTest after migration. |
| pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/AggregateMetricsClusterIntegrationTest.java | Removes the old standalone aggregate-metrics integration test. |
Comments suppressed due to low confidence (2)
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/StarTreeTest.java:100
createSchema()opens anInputStreamfrom the classloader but never closes it. Please wrap the stream in a try-with-resources to ensure the underlying resource is released (even in tests).
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/BigNumberOfSegmentsTest.java:49- The class is disabled via
@Test(..., enabled = false)here, buttestCreateManySegments()is also annotated@Test(enabled = false). Keeping the disablement in only one place avoids confusion when someone tries to re-enable the test later.
You can also share your feedback on Copilot code review. Take the survey.
Summary
AggregateMetrics,BigNumberOfSegments,CLPEncodingRealtime,GroupByOptions,GroupByTrimming,RowExpression,StarTree) toorg.apache.pinot.integration.tests.custompackageCustomDataQueryClusterIntegrationTestand share a single Pinot cluster via@BeforeSuite/@AfterSuitelifecycle, eliminating 7 redundant cluster startupsGroupByEnableTrimOptionIntegrationTest,StarTreeFunctionParametersIntegrationTest, andMultiColumnTextIndicesTestto reference the new class locationsTest plan
mvn test-compile -pl pinot-integration-tests -am -DskipTestscompiles successfully🤖 Generated with Claude Code